afonso/core-extra
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

removed some exceptions that were logged but ignore within services

Browse source
This commit is contained in:
Blake J. Harnden 2018-03-05 09:20:49 -08:00
parent 974559843a
commit ec79c7dba3
1 changed files with 9 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
daemon/core/service.py
View file

@ -292,10 +292,7 @@ class CoreServices(ConfigurableManager):
logger.info("starting service %s (%s)", service._name, service._startindex) logger.info("starting service %s (%s)", service._name, service._startindex)
for directory in service._dirs: for directory in service._dirs:
try: node.privatedir(directory)
node.privatedir(directory)
except:
logger.exception("Error making node %s dir %s", node.name, directory)
for filename in service.getconfigfilenames(node.objid, services): for filename in service.getconfigfilenames(node.objid, services):
cfg = service.generateconfig(node, filename, services) cfg = service.generateconfig(node, filename, services)
@ -305,11 +302,8 @@ class CoreServices(ConfigurableManager):
return return
for args in service.getstartup(node, services): for args in service.getstartup(node, services):
try: # TODO: this wait=False can be problematic!
# TODO: this wait=False can be problematic! node.cmd(args, wait=False)
node.cmd(args, wait=False)
except:
logger.exception("error starting command %s", args)
def bootnodecustomservice(self, node, service, services, use_startup_service): def bootnodecustomservice(self, node, service, services, use_startup_service):
""" """
@ -322,13 +316,9 @@ class CoreServices(ConfigurableManager):
:param bool use_startup_service: flag to use startup services or not :param bool use_startup_service: flag to use startup services or not
:return: nothing :return: nothing
""" """
logger.info("starting service(%s) %s (%s)(custom)", logger.info("starting service(%s) %s (%s)(custom)", service, service._name, service._startindex)
service, service._name, service._startindex)
for directory in service._dirs: for directory in service._dirs:
try: node.privatedir(directory)
node.privatedir(directory)
except:
logger.exception("error making node %s dir %s", node.name, directory)
logger.info("service configurations: %s", service._configs) logger.info("service configurations: %s", service._configs)
for i, filename in enumerate(service._configs): for i, filename in enumerate(service._configs):
@ -351,11 +341,8 @@ class CoreServices(ConfigurableManager):
return return
for args in service._startup: for args in service._startup:
try: # TODO: this wait=False can be problematic!
# TODO: this wait=False can be problematic! node.cmd(args, wait=False)
node.cmd(args, wait=False)
except:
logger.exception("error starting command %s", args)
def copyservicefile(self, node, filename, cfg): def copyservicefile(self, node, filename, cfg):
""" """
@ -776,11 +763,8 @@ class CoreServices(ConfigurableManager):
cfg = self.getservicefiledata(s, filename) cfg = self.getservicefiledata(s, filename)
if cfg is None: if cfg is None:
cfg = s.generateconfig(node, filename, services) cfg = s.generateconfig(node, filename, services)
try:
node.nodefile(filename, cfg) node.nodefile(filename, cfg)
except:
logger.exception("error in configure file: %s", filename)
fail += "%s," % s._name
fail_data = "" fail_data = ""
if len(fail) > 0: if len(fail) > 0: