afonso/core-extra
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

avoid piping subprocess command output when not waiting for results

Browse source
This commit is contained in:
Blake Harnden 2020-06-04 21:14:11 -07:00
parent 7b2dd59c81
commit eaa05c34ba
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
daemon/core/utils.py
View file

@ -228,7 +228,8 @@ def cmd(
if shell is False: if shell is False:
args = shlex.split(args) args = shlex.split(args)
try: try:
p = Popen(args, stdout=PIPE, stderr=PIPE, env=env, cwd=cwd, shell=shell) output = PIPE if wait else DEVNULL
p = Popen(args, stdout=output, stderr=output, env=env, cwd=cwd, shell=shell)
if wait: if wait:
stdout, stderr = p.communicate() stdout, stderr = p.communicate()
stdout = stdout.decode("utf-8").strip() stdout = stdout.decode("utf-8").strip()