moved linkconfig to CoreNetworkBase and made linkconfig defined the same across the board

daemon/core/nodes/base.py

@@ -1165,6 +1165,32 @@ class CoreNetworkBase(NodeBase):
 
         return all_links
 
+    def linkconfig(
+        self,
+        netif: CoreInterface,
+        bw: float = None,
+        delay: float = None,
+        loss: float = None,
+        duplicate: float = None,
+        jitter: float = None,
+        netif2: float = None,
+        devname: str = None,
+    ) -> None:
+        """
+        Configure link parameters by applying tc queuing disciplines on the interface.
+
+        :param netif: interface one
+        :param bw: bandwidth to set to
+        :param delay: packet delay to set to
+        :param loss: packet loss to set to
+        :param duplicate: duplicate percentage to set to
+        :param jitter: jitter to set to
+        :param netif2: interface two
+        :param devname: device name
+        :return: nothing
+        """
+        raise NotImplementedError
+
 
 class Position:
     """

daemon/core/nodes/physical.py

@@ -151,6 +151,7 @@ class PhysicalNode(CoreNodeBase):
         duplicate: float = None,
         jitter: float = None,
         netif2: CoreInterface = None,
+        devname: str = None,
     ) -> None:
         """
         Apply tc queing disciplines using linkconfig.
@@ -158,13 +159,7 @@ class PhysicalNode(CoreNodeBase):
         linux_bridge = CoreNetwork(session=self.session, start=False)
         linux_bridge.up = True
         linux_bridge.linkconfig(
-            netif,
-            bw=bw,
-            delay=delay,
-            loss=loss,
-            duplicate=duplicate,
-            jitter=jitter,
-            netif2=netif2,
+            netif, bw, delay, loss, duplicate, jitter, netif2, devname
         )
         del linux_bridge