afonso/core-extra
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

updated service loading to catch on_load exceptions and ignore service

Browse source
This commit is contained in:
Blake Harnden 2019-09-30 09:33:17 -07:00
parent 1248982d8c
commit d6cf09e4b8
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
daemon/core/services/coreservices.py
View file

@ -249,6 +249,7 @@ class ServiceManager(object):
:param CoreService service: service to add :param CoreService service: service to add
:return: nothing :return: nothing
:raises ValueError: when service cannot be loaded
""" """
name = service.name name = service.name
logging.debug("loading service: class(%s) name(%s)", service.__name__, name) logging.debug("loading service: class(%s) name(%s)", service.__name__, name)
@ -261,6 +262,13 @@ class ServiceManager(object):
for executable in service.executables: for executable in service.executables:
which(executable, required=True) which(executable, required=True)
# validate service on load succeeds
try:
service.on_load()
except Exception as e:
logging.exception("error during service(%s) on load", service.name)
raise ValueError(e)
# make service available # make service available
cls.services[name] = service cls.services[name] = service
@ -289,7 +297,6 @@ class ServiceManager(object):
for service in services: for service in services:
if not service.name: if not service.name:
continue continue
service.on_load()
try: try:
cls.add(service) cls.add(service)