changes to support better type checking for retrieving an arbitrary node from a session, get_node now requires an expected class that the node would be an instance of, if the returned node is not an instance a CoreError is thrown, this also helps editors pick up expected types to account for variable/function usage better as well

daemon/core/emane/commeffect.py

@@ -10,6 +10,7 @@ from lxml import etree
 
 from core.config import ConfigGroup, Configuration
 from core.emane import emanemanifest, emanemodel
+from core.emane.nodes import EmaneNet
 from core.nodes.interface import CoreInterface
 from core.xml import emanexml
 
@@ -137,7 +138,7 @@ class EmaneCommEffectModel(emanemodel.EmaneModel):
         # TODO: batch these into multiple events per transmission
         # TODO: may want to split out seconds portion of delay and jitter
         event = CommEffectEvent()
-        emane_node = self.session.get_node(self.id)
+        emane_node = self.session.get_node(self.id, EmaneNet)
         nemid = emane_node.getnemid(netif)
         nemid2 = emane_node.getnemid(netif2)
         mbw = bw

daemon/core/emane/emanemanager.py

@@ -21,7 +21,7 @@ from core.emane.rfpipe import EmaneRfPipeModel
 from core.emane.tdma import EmaneTdmaModel
 from core.emulator.enumerations import ConfigDataTypes, RegisterTlvs
 from core.errors import CoreCommandError, CoreError
-from core.nodes.base import CoreNode
+from core.nodes.base import CoreNode, NodeBase
 from core.nodes.interface import CoreInterface
 from core.nodes.network import CtrlNet
 from core.xml import emanexml
@@ -801,8 +801,8 @@ class EmaneManager(ModelManager):
         zbit_check = z.bit_length() > 16 or z < 0
         if any([xbit_check, ybit_check, zbit_check]):
             logging.error(
-                "Unable to build node location message, received lat/long/alt exceeds coordinate "
-                "space: NEM %s (%d, %d, %d)",
+                "Unable to build node location message, received lat/long/alt "
+                "exceeds coordinate space: NEM %s (%d, %d, %d)",
                 nemid,
                 x,
                 y,
@@ -812,7 +812,7 @@ class EmaneManager(ModelManager):
 
         # generate a node message for this location update
         try:
-            node = self.session.get_node(n)
+            node = self.session.get_node(n, NodeBase)
         except CoreError:
             logging.exception(
                 "location event NEM %s has no corresponding node %s", nemid, n

daemon/core/emane/emanemodel.py

@@ -7,6 +7,7 @@ from typing import Dict, List
 
 from core.config import ConfigGroup, Configuration
 from core.emane import emanemanifest
+from core.emane.nodes import EmaneNet
 from core.emulator.enumerations import ConfigDataTypes
 from core.errors import CoreError
 from core.location.mobility import WirelessModel
@@ -148,7 +149,7 @@ class EmaneModel(WirelessModel):
         :return: nothing
         """
         try:
-            wlan = self.session.get_node(self.id)
+            wlan = self.session.get_node(self.id, EmaneNet)
             wlan.setnempositions(moved_netifs)
         except CoreError:
             logging.exception("error during update")