daemon: removing python tlv related code and tests related to it

daemon/core/services/coreservices.py

@@ -109,114 +109,6 @@ class ServiceDependencies:
         return self.boot_paths
 
 
-class ServiceShim:
-    keys: List[str] = [
-        "dirs",
-        "files",
-        "startidx",
-        "cmdup",
-        "cmddown",
-        "cmdval",
-        "meta",
-        "starttime",
-    ]
-
-    @classmethod
-    def tovaluelist(cls, node: CoreNode, service: "CoreService") -> str:
-        """
-        Convert service properties into a string list of key=value pairs,
-        separated by "|".
-
-        :param node: node to get value list for
-        :param service: service to get value list for
-        :return: value list string
-        """
-        start_time = 0
-        start_index = 0
-        valmap = [
-            service.dirs,
-            service.configs,
-            start_index,
-            service.startup,
-            service.shutdown,
-            service.validate,
-            service.meta,
-            start_time,
-        ]
-        if not service.custom:
-            valmap[1] = service.get_configs(node)
-            valmap[3] = service.get_startup(node)
-        vals = ["%s=%s" % (x, y) for x, y in zip(cls.keys, valmap)]
-        return "|".join(vals)
-
-    @classmethod
-    def fromvaluelist(cls, service: "CoreService", values: List[str]) -> None:
-        """
-        Convert list of values into properties for this instantiated
-        (customized) service.
-
-        :param service: service to get value list for
-        :param values: value list to set properties from
-        :return: nothing
-        """
-        # TODO: support empty value? e.g. override default meta with ''
-        for key in cls.keys:
-            try:
-                cls.setvalue(service, key, values[cls.keys.index(key)])
-            except IndexError:
-                # old config does not need to have new keys
-                logger.exception("error indexing into key")
-
-    @classmethod
-    def setvalue(cls, service: "CoreService", key: str, value: str) -> None:
-        """
-        Set values for this service.
-
-        :param service: service to get value list for
-        :param key: key to set value for
-        :param value: value of key to set
-        :return: nothing
-        """
-        if key not in cls.keys:
-            raise ValueError("key `%s` not in `%s`" % (key, cls.keys))
-        # this handles data conversion to int, string, and tuples
-        if value:
-            if key == "startidx":
-                value = int(value)
-            elif key == "starttime":
-                value = float(value)
-            elif key == "meta":
-                value = str(value)
-            else:
-                value = utils.make_tuple_fromstr(value, str)
-
-        if key == "dirs":
-            service.dirs = value
-        elif key == "files":
-            service.configs = value
-        elif key == "cmdup":
-            service.startup = value
-        elif key == "cmddown":
-            service.shutdown = value
-        elif key == "cmdval":
-            service.validate = value
-        elif key == "meta":
-            service.meta = value
-
-    @classmethod
-    def servicesfromopaque(cls, opaque: str) -> List[str]:
-        """
-        Build a list of services from an opaque data string.
-
-        :param opaque: opaque data string
-        :return: services
-        """
-        servicesstring = opaque.split(":")
-        if servicesstring[0] != "service":
-            return []
-        return servicesstring[1].split(",")
-
-
 class ServiceManager:
     """
     Manages services available for CORE nodes to use.