fixed session.add_hook to not require a source, since it was not typically used an None was being passed, cleaned up some bad type hinting in related to session.py
This commit is contained in:
parent
4b6ba90331
commit
bcd9e4ceb1
8 changed files with 26 additions and 22 deletions
|
@ -1,4 +1,4 @@
|
|||
from typing import List, Optional
|
||||
from typing import List, Optional, Union
|
||||
|
||||
import netaddr
|
||||
|
||||
|
@ -21,7 +21,7 @@ class IdGen:
|
|||
|
||||
|
||||
def link_config(
|
||||
network: CoreNetworkBase,
|
||||
node: Union[CoreNetworkBase, PhysicalNode],
|
||||
interface: CoreInterface,
|
||||
link_options: LinkOptions,
|
||||
devname: str = None,
|
||||
|
@ -30,7 +30,7 @@ def link_config(
|
|||
"""
|
||||
Convenience method for configuring a link,
|
||||
|
||||
:param network: network to configure link for
|
||||
:param node: network to configure link for
|
||||
:param interface: interface to configure
|
||||
:param link_options: data to configure link with
|
||||
:param devname: device name, default is None
|
||||
|
@ -49,10 +49,10 @@ def link_config(
|
|||
|
||||
# hacky check here, because physical and emane nodes do not conform to the same
|
||||
# linkconfig interface
|
||||
if not isinstance(network, (EmaneNet, PhysicalNode)):
|
||||
if not isinstance(node, (EmaneNet, PhysicalNode)):
|
||||
config["devname"] = devname
|
||||
|
||||
network.linkconfig(**config)
|
||||
node.linkconfig(**config)
|
||||
|
||||
|
||||
class NodeOptions:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue