updates to force CoreCommandError to contain string values for stderr and stdout, couple bugfixes in handling bad commands when using execute commands from tlv based api or coresendmsg, also updates to coresendmsg to display everything in lowercase to mimic previous look and feel, however coresendmg will now work regardless of casing to avoid breaking things again

daemon/core/api/tlv/corehandlers.py

@@ -880,12 +880,7 @@ class CoreHandler(socketserver.BaseRequestHandler):
                         except CoreCommandError as e:
                             res = e.stderr
                             status = e.returncode
-                    logging.info(
-                        "done exec cmd=%s with status=%d res=(%d bytes)",
-                        command,
-                        status,
-                        len(res),
-                    )
+                    logging.info("done exec cmd=%s with status=%d", command, status)
                     if message.flags & MessageFlags.TEXT.value:
                         tlv_data += coreapi.CoreExecuteTlv.pack(
                             ExecuteTlvs.RESULT.value, res

daemon/core/emane/emanemanager.py

@@ -836,7 +836,6 @@ class EmaneManager(ModelManager):
             result = True
         except CoreCommandError:
             result = False
-
         return result
 
 

daemon/core/nodes/base.py

@@ -522,7 +522,6 @@ class CoreNode(CoreNodeBase):
             self.host_cmd(f"kill -0 {self.pid}")
         except CoreCommandError:
             return False
-
         return True
 
     def startup(self) -> None:

daemon/core/nodes/docker.py

@@ -35,7 +35,7 @@ class DockerClient:
         output = self.run(args)
         data = json.loads(output)
         if not data:
-            raise CoreCommandError(-1, args, f"docker({self.name}) not present")
+            raise CoreCommandError(1, args, f"docker({self.name}) not present")
         return data[0]
 
     def is_alive(self) -> bool:

daemon/core/nodes/lxd.py

@@ -34,7 +34,7 @@ class LxdClient:
         output = self.run(args)
         data = json.loads(output)
         if not data:
-            raise CoreCommandError(-1, args, f"LXC({self.name}) not present")
+            raise CoreCommandError(1, args, f"LXC({self.name}) not present")
         return data[0]
 
     def is_alive(self) -> bool:

daemon/core/utils.py

@@ -231,14 +231,17 @@ def cmd(
         p = Popen(args, stdout=PIPE, stderr=PIPE, env=env, cwd=cwd, shell=shell)
         if wait:
             stdout, stderr = p.communicate()
+            stdout = stdout.decode("utf-8").strip()
+            stderr = stderr.decode("utf-8").strip()
             status = p.wait()
             if status != 0:
                 raise CoreCommandError(status, args, stdout, stderr)
-            return stdout.decode("utf-8").strip()
+            return stdout
         else:
             return ""
-    except OSError:
-        raise CoreCommandError(-1, args)
+    except OSError as e:
+        logging.error("cmd error: %s", e.strerror)
+        raise CoreCommandError(1, args, "", e.strerror)
 
 
 def file_munge(pathname: str, header: str, text: str) -> None: