logging.info for more important loggings and logging.debug for less important loggings that user might not care about

This commit is contained in:
Huy Pham 2020-01-29 16:08:36 -08:00
parent 6aa7d2175d
commit 6c89ba1abb
14 changed files with 132 additions and 62 deletions

View file

@ -25,6 +25,7 @@ class CanvasWirelessEdge:
dst: int,
canvas: "CanvasGraph",
):
logging.debug("Draw wireless link from node %s to node %s", src, dst)
self.token = token
self.src = src
self.dst = dst
@ -167,6 +168,7 @@ class CanvasEdge:
self.check_wireless()
self.canvas.tag_raise(self.src)
self.canvas.tag_raise(self.dst)
logging.debug("Draw wired link from node %s to node %s", self.src, dst)
def is_wireless(self) -> [bool, bool]:
src_node = self.canvas.nodes[self.src]
@ -198,6 +200,7 @@ class CanvasEdge:
src_node.add_antenna()
def delete(self):
logging.debug("Delete canvas edge, id: %s", self.id)
self.canvas.delete(self.id)
if self.link:
self.canvas.delete(self.text_src)

View file

@ -216,6 +216,7 @@ class CanvasGraph(tk.Canvas):
"""
# draw existing nodes
for core_node in session.nodes:
logging.debug("Draw node %s", core_node)
# peer to peer node is not drawn on the GUI
if NodeUtils.is_ignore_node(core_node.type):
continue
@ -231,7 +232,7 @@ class CanvasGraph(tk.Canvas):
# draw existing links
for link in session.links:
logging.info("drawing link: %s", link)
logging.debug("Draw link: %s", link)
canvas_node_one = self.core.canvas_nodes[link.node_one_id]
node_one = canvas_node_one.core_node
canvas_node_two = self.core.canvas_nodes[link.node_two_id]
@ -388,7 +389,6 @@ class CanvasGraph(tk.Canvas):
# set dst node and snap edge to center
edge.complete(self.selected)
logging.debug("drawing edge token: %s", edge.token)
self.edges[edge.token] = edge
node_src = self.nodes[edge.src]
@ -508,7 +508,7 @@ class CanvasGraph(tk.Canvas):
logging.debug("click press(%s): %s", self.cursor, selected)
x_check = self.cursor[0] - self.offset[0]
y_check = self.cursor[1] - self.offset[1]
logging.debug("clock press ofset(%s, %s)", x_check, y_check)
logging.debug("click press offset(%s, %s)", x_check, y_check)
is_node = selected in self.nodes
if self.mode == GraphMode.EDGE and is_node:
x, y = self.coords(selected)
@ -545,7 +545,8 @@ class CanvasGraph(tk.Canvas):
self.select_object(node.id)
self.selected = selected
logging.info(
"selected coords: (%s, %s)",
"selected node(%s), coords: (%s, %s)",
node.core_node.name,
node.core_node.position.x,
node.core_node.position.y,
)
@ -631,7 +632,6 @@ class CanvasGraph(tk.Canvas):
self.select_box.shape_motion(x, y)
def click_context(self, event: tk.Event):
logging.info("context event: %s", self.context)
if not self.context:
selected = self.get_selected(event)
canvas_node = self.nodes.get(selected)
@ -796,14 +796,14 @@ class CanvasGraph(tk.Canvas):
self.tag_raise(component)
def update_grid(self):
logging.info("updating grid show: %s", self.show_grid.get())
logging.debug("Show grid: %s", self.show_grid.get())
if self.show_grid.get():
self.itemconfig(tags.GRIDLINE, state=tk.NORMAL)
else:
self.itemconfig(tags.GRIDLINE, state=tk.HIDDEN)
def set_wallpaper(self, filename: str):
logging.info("setting wallpaper: %s", filename)
logging.debug("Set wallpaper: %s", filename)
if filename:
img = Image.open(filename)
self.wallpaper = img
@ -835,14 +835,11 @@ class CanvasGraph(tk.Canvas):
def copy(self):
if self.selection:
logging.debug(
"store current selection to to_copy, number of nodes: %s",
len(self.selection),
)
logging.debug("Copy %s nodes", len(self.selection))
self.to_copy = self.selection.keys()
def paste(self):
logging.debug("copy")
logging.debug("Paste")
# maps original node canvas id to copy node canvas id
copy_map = {}
# the edges that will be copy over

View file

@ -1,3 +1,4 @@
import logging
import tkinter as tk
from tkinter import font
from typing import TYPE_CHECKING
@ -41,6 +42,9 @@ class CanvasNode:
self.id = self.canvas.create_image(
x, y, anchor=tk.CENTER, image=self.image, tags=tags.NODE
)
logging.debug(
"Draw canvas node for node(%s), canvas id: %s", core_node.name, self.id
)
text_font = font.Font(family="TkIconFont", size=12)
label_y = self._get_label_y()
self.text_id = self.canvas.create_text(
@ -64,9 +68,10 @@ class CanvasNode:
self.canvas.tag_bind(self.id, "<Leave>", self.on_leave)
def delete(self):
logging.debug("Delete canvas node for %s", self.core_node)
self.canvas.delete(self.id)
self.canvas.delete(self.text_id)
self.delete_antennae()
self.delete_antennas()
def add_antenna(self):
x, y = self.canvas.coords(self.id)
@ -84,14 +89,16 @@ class CanvasNode:
"""
delete one antenna
"""
logging.debug("Delete an antenna on %s", self.core_node.name)
if self.antennae:
antenna_id = self.antennae.pop()
self.canvas.delete(antenna_id)
def delete_antennae(self):
def delete_antennas(self):
"""
delete all antennas
"""
logging.debug("Remove all antennas for %s", self.core_node.name)
for antenna_id in self.antennae:
self.canvas.delete(antenna_id)
self.antennae.clear()
@ -244,6 +251,7 @@ class CanvasNode:
dialog.show()
def show_mobility_player(self):
logging.debug("Mobility player for %s", self.core_node.name)
self.canvas.context = None
mobility_player = self.app.core.mobility_players[self.core_node.id]
mobility_player.show()

View file

@ -86,6 +86,7 @@ class Shape:
outline=self.shape_data.border_color,
width=self.shape_data.border_width,
)
logging.debug("Create oval, id(%s)", self.id)
self.draw_shape_text()
elif self.shape_type == ShapeType.RECTANGLE:
self.id = self.canvas.create_rectangle(
@ -99,6 +100,7 @@ class Shape:
outline=self.shape_data.border_color,
width=self.shape_data.border_width,
)
logging.debug("Create rectangle, id(%s)", self.id)
self.draw_shape_text()
elif self.shape_type == ShapeType.TEXT:
font = self.get_font()
@ -110,6 +112,7 @@ class Shape:
fill=self.shape_data.text_color,
font=font,
)
logging.debug("Create text, id(%s)", self.id)
else:
logging.error("unknown shape type: %s", self.shape_type)
self.created = True
@ -144,6 +147,7 @@ class Shape:
def shape_complete(self, x: float, y: float):
for component in tags.ABOVE_SHAPE:
self.canvas.tag_raise(component)
logging.debug("Complete shape, id(%s)", self.id)
s = ShapeDialog(self.app, self.app, self)
s.show()
@ -163,6 +167,7 @@ class Shape:
self.canvas.move(self.text_id, x_offset, y_offset)
def delete(self):
logging.debug("Delete shape, id(%s)", self.id)
self.canvas.delete(self.id)
self.canvas.delete(self.text_id)